Hi Roger, Thanks for the review.
> On Jan 31, 2020, at 12:05 PM, Roger Riggs <roger.ri...@oracle.com> wrote: > > The spec text describing the current behavior is ok. > > On 1/16/20 8:35 PM, Brian Burkhalter wrote: >> This issue [1] attempts to reinstate the change for [2] which was backed out >> to fix [3] thereby maintaining longstanding behavior. The proposed change >> [4] modifies the specification to increment the line number also when EOF is >> encountered and is not immediately preceded by a line terminator. If this >> all seems reasonable then a CSR will be filed after the code review. > > LineNumberReader: > > 55: I would probably use 'EOL' instead of 'TERM’. Yes, that is better. >> >> One thing I am uncertain about is the change to skip() at lines 293-295 of >> LineNumberReader. I am not sure that those lines should be added. > Leave them in. > Not changing prevChar would be misleading since the prevChar isn't adjecent > to the next read. OK. I’ll change /TERM/EOL/ but not post another webrev unless there are further comments. I will wait to check it in until Monday in case someone has comments. Thanks, Brian
