Hi Matthias, I think this is good.
Best regards Christoph > -----Original Message----- > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf > Of Baesken, Matthias > Sent: Donnerstag, 20. Februar 2020 14:15 > To: core-libs-dev@openjdk.java.net > Subject: [CAUTION] RFR [XS]: 8238947: tools/jpackage tests fail with old > rpmbuild versions > > Hello, please review this small change adjusting the minimal rpmbuild version > of tools/jpackage tests . > > Currently the tools/jpackage tests, for example > jdk/test/jdk/tools/jpackage/linux/AppCategoryTest.java fail on older distros > with rpmbuild tools < 4.10 . > This can be seen on Suse Linux (SLES11) with rpmbuild 4.4 and on RedHat 6 > with rpmbuild 4.8 . > For example, rpmbuild returns an unexpected "rpmbuild: no spec files given > for build" when calling : > > > rpmbuild --eval=%{_target_cpu} > > x86_64 > > rpmbuild: no spec files given for build > > Probably we should check for at least rpmbuild version 4.10 when executing > the tests (on Suse Linux 12 and on RedHat 7+ we have rpmbuild 4.11 or > higher). > > > Bug/webrev : > > https://bugs.openjdk.java.net/browse/JDK-8238947 > > http://cr.openjdk.java.net/~mbaesken/webrevs/8238947.0/ > > Thanks, Matthias