Oh okay. Then it looks okay to me. Cheers, Thomas
On Mon, Feb 24, 2020 at 12:56 PM Doerr, Martin <[email protected]> wrote: > Hi Thomas, > > > > thanks for the quick review. > > > > ATTRIBUTE_ALIGNED is defined in hotspot. I can’t use it for > src/jdk.jdwp.agent/share/native/libjdwp/ArrayReferenceImpl.c. > > > > Christoph had already suggested to make it available for core libs, too, > but I haven’t found a good place for it. > > > > Best regards, > > Martin > > > > > > *From:* Thomas Stüfe <[email protected]> > *Sent:* Montag, 24. Februar 2020 12:52 > *To:* Doerr, Martin <[email protected]> > *Cc:* [email protected]; Lindenmaier, Goetz < > [email protected]>; Langer, Christoph <[email protected]> > *Subject:* Re: RFR(XS): 8239856: [ntintel] asserts about copying > unaligned array element > > > > Hi Martin, > > > > maybe use ATTRIBUTE_ALIGNED instead? > > > > Cheers, Thomas > > > > On Mon, Feb 24, 2020 at 12:44 PM Doerr, Martin <[email protected]> > wrote: > > Hi, > > > > we had fixed stack array alignment for Windows 32 bit with JDK-8220348. > > However, there are also stack allocated jlong and jdouble used as source > for SetLongArrayRegion and SetDoubleArrayRegion with insufficient alignment > for this platform. > > > > Here’s my proposed fix: > > > http://cr.openjdk.java.net/~mdoerr/8239856_win32_long_double_align/webrev.00/ > > > > Please review. > > > > Best regards, > > Martin > > > >
