Thanks Lance. I've just sent out an updated webrev with the shortened comments:
http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333.01/ On Tue, Mar 3, 2020 at 7:00 PM Lance Andersen <lance.ander...@oracle.com> wrote: > > I think this all looks OK. I would consider the same comment clean-up in > JmodTask.java as well > > Best > Lance > > On Mar 3, 2020, at 11:27 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 03/03/2020 11:01, Volker Simonis wrote: > > Hi, > > can I please get a review for the following small fix: > > http://cr.openjdk.java.net/~simonis/webrevs/2020/8240333/ > https://bugs.openjdk.java.net/browse/JDK-8240333 > > > The code changes okay but I think the comment needs a bit of clean-up. Maybe > drop L96-97 so that it just says that it preserves the attributes that don't > change. > > -Alan. > > > > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com > > >
