Hi Joe, > On Mar 30, 2020, at 6:31 AM, Chris Hegarty <chris.hega...@oracle.com> wrote: > >> Full webrev for review include including tests: >> >> http://cr.openjdk.java.net/~darcy/8241374.0/ >> <http://cr.openjdk.java.net/~darcy/8241374.0/> >> >> and the companion CSR: >> >> https://bugs.openjdk.java.net/browse/JDK-8241805 >> <https://bugs.openjdk.java.net/browse/JDK-8241805> > > Looks good to me.
Likewise. > I do like the explanatory paragraph about the asymmetry in the range of two's > complement integer values. An alternative, or addition, would be a link to > JLS 4.2.1 - Integral Types and Values [1], which shows the asymmetry from a > language perspective. I also like this suggestion. Brian > -Chris. > > [1] https://docs.oracle.com/javase/specs/jls/se14/html/jls-4.html#jls-4.2.1 > <https://docs.oracle.com/javase/specs/jls/se14/html/jls-4.html#jls-4.2.1>
