> De: "mandy chung" <mandy.ch...@oracle.com> > À: "Remi Forax" <fo...@univ-mlv.fr> > Cc: "Maurizio Cimadamore" <maurizio.cimadam...@oracle.com>, "core-libs-dev" > <core-libs-dev@openjdk.java.net> > Envoyé: Mardi 28 Avril 2020 20:09:07 > Objet: Re: RFR 8243491: Implementation of Foreign-Memory Access API (Second > Incubator)
> On 4/28/20 12:58 AM, [ mailto:fo...@univ-mlv.fr | fo...@univ-mlv.fr ] wrote: >>>> I don't think you need to store all the values into static fields, you can >>>> directly do a ldc + aaload with the right index right where you need it, >>> I think this is what you are thinking as reported in JDK-8243492: >>> [ >>> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8239578/webrev.01-accessor/ >>> | >>> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8239578/webrev.01-accessor/ >>> ] >> if the accessors are declared ACC_STATIC, yes ! > Thanks for catching this and this way will not be hit JDK-824349. > Here is the revised patch: > [ http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8239578/webrev.02/ | > http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8239578/webrev.02/ ] Looks good to me ! > Maurizio - do you mind remerge MemoryAccessVarHandleGenerator.java with > webrev.02? > thanks > Mandy cheers, Rémi
