Looks good assuming the patch was tested with 64bit build.
- Alexey
On 4/30/2020 10:12 AM, Baesken, Matthias wrote:
Hello, please look into this small fix for a link error we faced on
Windows 32bit.
Currently we run into this link error :
jpackageapplauncher
* For target
support_native_jdk.incubator.jpackage_jpackageapplauncher_BUILD_JPACKAGE_APPLAUNCHEREXE_link:
LINK : fatal error LNK1561: entry point must be defined
looks like the wWinMain signature in
src\jdk.incubator.jpackage\windows\native\applauncher\WinLauncher.cpp
has to be adjusted.
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8244183
http://cr.openjdk.java.net/~mbaesken/webrevs/8244183.0/
Thanks, Matthias
