Thanks Roger.
I figure I could have gotten away without an additional reviewer. :-) However, I
asked for a review because I wanted someone to cross-check my decision not to
file a CSR for this, despite most specification changes requiring a CSR. I also
wanted to model behavior for new community members.
s'marks
On 5/1/20 7:57 AM, Roger Riggs wrote:
+1,
BTW, Stuart you are a Reviewer, no need for a 2nd.
Roger
On 5/1/20 12:02 AM, Stuart Marks wrote:
Hi Jay,
OK, welcome! I'll sponsor this changeset for you. It's pretty simple, so I'll
just paste the exported changeset below. (For complicated changesets, you'll
have to ask a sponsor to host a webrev on cr.openjdk.java.net for you.) Please
check the Contributed-by line in the changeset to make sure the attribution is
correct. I just copied the From: line from your email, but if you want it to
be different, please let me know.
I'll update the bug report with a pointer to this email thread.
https://bugs.openjdk.java.net/browse/JDK-6415694
Could I get a Reviewer to review this? Thanks.
(I noticed that the anachronistic <code> markup is used here instead of the
preferred {@code ...} javadoc tag. However, <code> is used all over this
package, so I didn't think that changing it in just one place would be helpful.)
I'll also note again that since this is merely an editorial wording change to
the specification, I don't think it needs a CSR request.
Thanks,
s'marks
# HG changeset patch
# User smarks
# Date 1588290431 25200
# Thu Apr 30 16:47:11 2020 -0700
# Node ID 1f5b3876d1500a2e77d6e39d079649964ba6dd26
# Parent fe6548dc92de4c875467c968ee37e7c9bbee1697
6415694: Clarification in Javadoc for java.rmi.AlreadyBoundException
Reviewed-by: XXX
Contributed-by: Jayashree Sk1 <jayashre...@in.ibm.com>
diff -r fe6548dc92de -r 1f5b3876d150
src/java.rmi/share/classes/java/rmi/AlreadyBoundException.java
--- a/src/java.rmi/share/classes/java/rmi/AlreadyBoundException.java Thu Apr
30 15:21:15 2020 -0700
+++ b/src/java.rmi/share/classes/java/rmi/AlreadyBoundException.java Thu Apr
30 16:47:11 2020 -0700
@@ -26,8 +26,8 @@
/**
* An <code>AlreadyBoundException</code> is thrown if an attempt
- * is made to bind an object in the registry to a name that already
- * has an associated binding.
+ * is made to bind an object to a name that already
+ * has an associated binding in the registry.
*
* @since 1.1
* @author Ann Wollrath
On 4/29/20 10:24 PM, Jayashree Sk1 wrote:
Thanks for the review comment Stuart. Yes, I will need a sponsor, this is my
first time here in OpenJDK.
Regards!
Jay
-----Stuart Marks <stuart.ma...@oracle.com> wrote: -----
To: Jayashree Sk1 <jayashre...@in.ibm.com>
From: Stuart Marks <stuart.ma...@oracle.com>
Date: 04/30/2020 09:22AM
Cc: core-libs-dev@openjdk.java.net
Subject: [EXTERNAL] Re: RFR: 6415694 Clarification in Javadoc for
java.rmi.AlreadyBoundException
The change looks fine. Although this is in a normative portion of the
specification, the nature of the change is purely editorial, so I don't think it
needs a CSR.
Do you need a sponsor?
s'marks
On 4/29/20 2:57 AM, Jayashree Sk1 wrote:
Hi All,
Please find the below changes for the issues
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D6415694&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=rA_13vli8clPM_toR46hq8FVwH3XGr8z7cUfcQoqL-k&m=OXEC-w1xTWoJUyw_sRivRwIGmkHIUc3DllMsA_N3qIk&s=iesFFcE4NSOreLmf8vwdKzcdnFgjGE_SEERICPUFef4&e=
.
It is a description change, which was already approved by the reviewer.
Thanks!
diff -r 59b5bd9a7168
src/java.rmi/share/classes/java/rmi/AlreadyBoundException.java
--- a/src/java.rmi/share/classes/java/rmi/AlreadyBoundException.java Mon Mar
16 02:16:49 2020 -0400
+++ b/src/java.rmi/share/classes/java/rmi/AlreadyBoundException.java Mon Mar
30 15:45:43 2020 +0530
@@ -26,8 +26,8 @@
/**
* An <code>AlreadyBoundException</code> is thrown if an attempt
- * is made to bind an object in the registry to a name that already
- * has an associated binding.
+ * is made to bind an object to a name that already
+ * has an associated binding in the registry.
*
* @since 1.1
* @author Ann Wollrath
