Hi Vipin,

When you submit your revised patch addressing the input previously provided,  
please include a test case which exercises the various methods. 

Best
Lance

> On May 11, 2020, at 7:54 AM, Alan Bateman <alan.bate...@oracle.com> wrote:
> 
> On 11/05/2020 12:44, Claes Redestad wrote:
>> Hi Vipin,
>> 
>> making containsKey("key") return true without also ensuring the
>> other Map operations like get, put, .. work consistently and
>> transparently with String keys seem like a partial fix that will subtly
>> break operations like getOrDefault.
> Yeah, I think this one will require going through Attributes all the 
> consistency issues. The outcome may require a spec clarification to several 
> methods where it's not currently clear if the input is a String or a Name.
> 
> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>



Reply via email to