On 19/05/2020 20:35, Claes Redestad wrote:
Hi Jason, I guess overriding and marking the CharBuffer method final for consistency wouldn't hurt. Except I probably need to pass this through another CSR review. Also added test cases for char[] and String-based CharBuffers: http://cr.openjdk.java.net/~redestad/8215401/open.01/
Yes, CharBuffer sometimes needs attention default methods are added to CharSequence. In this case it shouldn't need anything but overriding the javadoc is okay (just missing @since 15).
For the test then you could expand it to test the views of heap and direct buffers (asCharBuffer).
-Alan
