Hi Alan, We (the ASM team) recommend to our users to check the byte 6 (and perhaps 7) instead of relying on ASM throwing an exception, because you may update the version of ASM but not the visitors your are using in your code.
It's less brittle than catching the IAE thrown by ASM. Rémi ----- Mail original ----- > De: "Alan Bateman" <alan.bate...@oracle.com> > À: "mandy chung" <mandy.ch...@oracle.com>, "core-libs-dev" > <core-libs-dev@openjdk.java.net>, "Remi Forax" > <fo...@univ-mlv.fr> > Envoyé: Mercredi 27 Mai 2020 18:16:33 > Objet: Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw > UnsupportedClassVersionError if the given bytes are > of an unsupported major or minor version > On 26/05/2020 22:46, Mandy Chung wrote: >> Lookup::defineHiddenClass currently throws IAE by ASM if the given >> bytes are of unsupported class file version. The implementation >> should catch and throw UnsupportedClassVersionError instead. >> >> webrev: >> http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8245432/webrev.00/ >> >> This patch also includes a spec clarification of @throws IAE if the >> the bytes has ACC_MODULE flag set to fix JDK-8245596. > Rémi - has there ever been any discussion in ASM about throwing more > specific exceptions? Only asking to see if we could avoid needing to > depend on the exception message here. > > -Alan
