Hi Stuart I think your changes read fine.
> On May 28, 2020, at 1:34 PM, Stuart Marks <[email protected]> wrote: > > I've updated the webrev a little bit in response to previous comments: > > http://cr.openjdk.java.net/~smarks/reviews/8245068/webrev.1/ Thinking about: --------- @deprecated The RMI Activation mechanism has been deprecated, and it may + * be removed from a future version. ———— Perhaps it might be a bit clearer to say “… from a future Java SE version”? I realize that is different from what is at: https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/lang/Compiler.html <https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/lang/Compiler.html>, but I thought it makes it clearer as to what “version” is referring to. Though that being said, and now looking back at what I did for the CORBA and Java EE module removal, I used the same wording as you are proposing, so all good… :-) > > I've also drafted a CSR request and a release note. Please review: > > CSR: > > https://bugs.openjdk.java.net/browse/JDK-8245860 I think the CSR is fine. I might suggest adding a comment to justify “low” for the compatibility impact for the JCK folks. I added myself as a reviewer. > > Release Note: > > https://bugs.openjdk.java.net/browse/JDK-8246021 Looks fine. Best, Lance > > Thanks, > > s'marks > > > On 5/26/20 12:35 PM, Stuart Marks wrote: >> Hi all, >> Here's the implementation of the recently-posted JEP 385, deprecation of RMI >> Activation for removal. >> I'm listing this as S ("small") since conceptually it's fairly small, though >> there are rather a large number of files changed. Essentially the changes >> are: >> - java.rmi.activation package spec: add deprecation warning >> - java.rmi module spec: link to activation package spec >> - java.rmi.activation public classes and interfaces: deprecate >> - various other files: suppress warnings >> - Activation.java: have the rmid tool emit a deprecation warning >> - rmid.properties: localized warning message >> Webrev: >> http://cr.openjdk.java.net/~smarks/reviews/8245068/webrev.0/ >> Bug ID: >> https://bugs.openjdk.java.net/browse/JDK-8245068 >> JEP: >> http://openjdk.java.net/jeps/385 >> Thanks, >> s'marks <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
