HI Jim,
StringJoiner.java: 173 and 241: put the OutOfMemoryException name on
the same line as the "new" (all one line).
Otherwise looks ok.
Thanks, Roger
On 6/1/20 3:51 PM, Jim Laskey wrote:
Thanks Martin.
On Jun 1, 2020, at 4:39 PM, Martin Buchholz <marti...@google.com> wrote:
Missing "throw"; We should have an assertThrows test method (many
people have written such, including myself).
+ try {
+ new StringJoiner(maxString, maxString, "").toString();
+ new AssertionError("Should have thrown OutOfMemoryError");
On Mon, Jun 1, 2020 at 8:58 AM Jim Laskey <james.las...@oracle.com> wrote:
Change NegativeArraySizeException to OutOfMemoryError. Tests added.
Cheers,
-- Jim
webrev: http://cr.openjdk.java.net/~jlaskey/8230743/webrev-00/index.html
<http://cr.openjdk.java.net/~jlaskey/8230743/webrev-00/index.html>
jbs: https://bugs.openjdk.java.net/browse/JDK-8230743
<https://bugs.openjdk.java.net/browse/JDK-8230743>
