I don't have a unix system to try this out on, but it looks like there is no net change when install-dir is neither "/usr" or "/user/local", so I'm good with it.

/Andy

On 6/8/2020 10:26 AM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].

Add support to jpackage to create Linux packages installing app images in '/usr' tree with splicing of the app image.

For --install-dir=/usr jpackag option the resulting Debian package will have the following layout:
- Launchers will be installed in `/usr/bin` directory
- Java runtime will be installed in `/usr/lib/$PACKAGE_NAME/runtime` directory - `app` directory of the app image will be installed in `/usr/lib/$PACKAGE_NAME/app` directory - copyright file will be installed in `/usr/share/doc/$PACKAGE_NAME/copyright` file

RPM package will have the following layout:
- Launchers will be installed in `/usr/bin` directory
- Java runtime will be installed in `/usr/lib/$PACKAGE_NAME/runtime` directory - `app` directory of the app image will be installed in `/usr/lib/$PACKAGE_NAME/app` directory

For --install-dir=/usr/local jpackag option the resulting Debian package will have the following layout:
- Launchers will be installed in `/usr/local/bin` directory
- Java runtime will be installed in `/usr/local/lib/$PACKAGE_NAME/runtime` directory - `app` directory of the app image will be installed in `/usr/local/lib/$PACKAGE_NAME/app` directory - copyright file will be installed in `/usr/share/doc/$PACKAGE_NAME/copyright` file

RPM package will have the following layout:
- Launchers will be installed in `/usr/local/bin` directory
- Java runtime will be installed in `/usr/local/lib/$PACKAGE_NAME/runtime` directory - `app` directory of the app image will be installed in `/usr/local/lib/$PACKAGE_NAME/app` directory

For any other prefixes starting with `/usr` no app image splicing will happen and package layout will be the same as for installing at the default `/opt` prefix.

- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8231283

[2] http://cr.openjdk.java.net/~asemenyuk/8231283/webrev.00

Reply via email to