Hi Andy,
Looks good. For changing "jpackagerTest.keychain" to
""jpackageTest.keychain" we can file followup bug for this, since SQE
depend on this value to be "jpackagerTest.keychain".
Thanks,
Alexander
On 6/5/20 2:27 PM, Alexey Semenyuk wrote:
In SigningBase.java:
---
KEYCHAIN = (value == null) ? "jpackagerTest.keychain" : value;
---
Is "jpackagerTest.keychain" some legacy string? Should not it be
"jpackageTest.keychain"?
- Alexey
On 6/5/2020 4:23 PM, Andy Herrick wrote:
Please review fix to issue [1] at [2].
The fix enables running jpackage signing tests on macos with user
supplied certificates.
[1] https://bugs.openjdk.java.net/browse/JDK-8246706
[2] http://cr.openjdk.java.net/~herrick/8246706/webrev.01/index.html
/Andy
