Looks good.
- Alexey
On 6/10/2020 2:27 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
To unpack msi we using /a argument which is not exactly an
installation. In this mode (Administrative installation) msi will
extract files and also creates .msi installer to install these files.
For some reason empty folders are not created during extraction, but
they will be created after installing administrative installation. So,
I think issue is not with jpackage, but instead we cannot verify empty
folder using this approach and thus check for empty folder was
disabled if msi is unpacked.
[1] https://bugs.openjdk.java.net/browse/JDK-8245788
[2] http://cr.openjdk.java.net/~almatvee/8245788/webrev.00/
Thanks,
Alexander
