Hi all,
thank you for the review, I updated the code and run the test.
best regards,
On 30/06/2020 23:15, Lance Andersen wrote:
Hi Ivan,
Looks fine to me also outside of the one extra line that Roger caught.
Best
Lance
On Jun 30, 2020, at 8:38 AM, Ivan Sipka <[email protected]
<mailto:[email protected]>> wrote:
Hi all,
kind reminder for RFR for JDK-8211974.
thank you,
----- Original Message -----
From: [email protected] <mailto:[email protected]>
To: [email protected]
<mailto:[email protected]>
Cc: [email protected] <mailto:[email protected]>
Sent: Thursday, June 4, 2020 7:40:27 PM GMT +00:00 GMT Britain,
Ireland, Portugal
Subject: request for review JDK-8211290
Hi all,
please review the following changeset:
http://cr.openjdk.java.net/~iignatyev/isipka/8211974/webrev.01/index.html
for the JBS issue https://bugs.openjdk.java.net/browse/JDK-8211974
which moves the files:
open/test/jdk/lib/testlibrary/java/util/jar/Compiler.java
open/test/jdk/lib/testlibrary/java/util/jar/JarBuilder.java
to files:
open/test/lib/jdk/test/lib/util/JarBuilder.java
open/test/lib/jdk/test/lib/compiler/Compiler.java
and changes the relevant jtreg specification tags in dependent tests:
open/test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java
open/test/jdk/jdk/nio/zipfs/jarfs/JFSTester.java
open/test/jdk/jdk/nio/zipfs/jarfs/MultiReleaseJarTest.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarHttpProperties.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarProperties.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarSecurity.java
open/test/jdk/java/util/jar/JarFile/JarBacktickManifest.java
open/test/jdk/java/net/URL/JarHandlerPkgPrefix/JarHandlerPkgPrefix.java
and adds relevant package imports to dependent file:
open/test/jdk/lib/testlibrary/java/util/jar/CreateMultiReleaseTestJars.java
jtreg command to run all dependent tests from repository root
jtreg -verbose:summary -ea -esa -a -conc:9 -jdk:build/linux-x64/jdk/
open/test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java
open/test/jdk/jdk/nio/zipfs/jarfs/JFSTester.java
open/test/jdk/jdk/nio/zipfs/jarfs/MultiReleaseJarTest.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarHttpProperties.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarProperties.java
open/test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarSecurity.java
open/test/jdk/java/util/jar/JarFile/JarBacktickManifest.java
open/test/jdk/java/net/URL/JarHandlerPkgPrefix/JarHandlerPkgPrefix.java
thank you,
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
