All looks good, except maybe Log.error().
I think Log.error() should have the same output whether verbose or not,
adding timestamp to the message only if verbose does not look right.
Problem is that Log.error() is used for two fundamentally different
purposes:
1.) by Main and Arguments to display the final error message when
jpackage is failing.
2.) by everyone else to display a serious warning message when jpackage
is continuing (sometimes failing further on, and sometimes not).
I wouldn't mind adding timestamps only when verbose in case (2), but I
don't think that's appropriate for case (1).
/ANdy
On 7/6/2020 8:27 PM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
Added timestamp to verbose and test output in form of [HH:mm:ss.SSS].
[1] https://bugs.openjdk.java.net/browse/JDK-8248261
[2] http://cr.openjdk.java.net/~almatvee/8248261/webrev.00/
Thanks,
Alexander
