looks good.
/Andy
On 7/9/2020 3:49 PM, Alexey Semenyuk wrote:
Hi Alexander,
Agreed with your suggestion. Updated review available at [1].
- Alexey
[1] http://cr.openjdk.java.net/~asemenyuk/8247229/webrev.01/webrev.01/
On 7/9/2020 12:21 AM, alexander.matv...@oracle.com wrote:
Hi Alexey,
Looks good. Only suggestion is to move CmdlineExecutor to Executor
class and make it configurable for error message and probably
attempts and timeout in case if we need such functionality in other
places.
Thanks,
Alexander
On 7/8/20 6:37 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Sometimes jpackage fails building .deb package due to failure of
`fakeroot` command with the same error message printed in stderr:
`semop(1): encountered an error: Invalid argument`.
The suggested fix is to rerun `fakeroot` command if it fails and the
known error message is pritnted to stederr.
- Alexey
[1] https://bugs.openjdk.java.net/browse/JDK-8247229
[2] http://cr.openjdk.java.net/~asemenyuk/8247229/webrev.00
