http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00 > 98 lines changed: 18 ins; 31 del; 49 mod;
Hi all, could you please review this small fix to make java/io/File/GetXSpace.java work again on windows? the test has been updated to work under cygwin, which includes the following changes: - GetXSpace.sh accepts CYGWIN_* as known OS and sets windows path to TMP var - uses the same regexp to parse df on windows as on other platforms - but uses 'FileSystem' field as Space's name, as opposed to 'MountedOn' on *nix, as on cygwin, MountedOn is cygwin path, while FileSystem is corresponding windows path, and the test expect Space's name to be appropriate path the patch also includes some small faceliftings: - printing out a bit more information to facilitate failure analyses, e.g. df output, exception stack traces - usage of try-w/-resources - remove of code duplication - usage of generics webrev: http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00 testing: java/io/File/GetXSpace.java 100 times on {linux,windows}-x64 JBS: https://bugs.openjdk.java.net/browse/JDK-6501010 Thanks, -- Igor
