Looks OK Joe > On Aug 24, 2020, at 5:44 PM, Joe Wang <huizhe.w...@oracle.com> wrote: > > Hi all, adding Roger's comment for the make file to webrev_02 (the only > change to webrev_01 is Docs.gmk): > > http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_02/ > > Thanks, > Joe > > On 8/21/20 12:49 PM, naoto.s...@oracle.com wrote: >> +1 >> >> Naoto >> >> On 8/21/20 12:24 PM, Lance Andersen wrote: >>> Hi Joe, >>> >>> This looks OK. >>> >>> >>> >>>> On Aug 21, 2020, at 2:23 PM, Joe Wang <huizhe.w...@oracle.com> wrote: >>>> >>>> Pelase review a patch to add the missing @return, @throws, @param >>>> statements in the java.xml package (excluding the DOM component). >>>> >>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8251561 >>>> CSR: https://bugs.openjdk.java.net/browse/JDK-8251995 >>>> >>>> webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_01/ >>>> >>>> Thanks, >>>> Joe >>> >>> >>> Best >>> Lance >>> ------------------ >>> >>> >>> >>> >>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >>> Oracle Java Engineering >>> 1 Network Drive >>> Burlington, MA 01803 >>> lance.ander...@oracle.com >>> >>> >>> >>> >
Best Lance ------------------ Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
