On 25/08/2020 18:00, Alexander Scherbatiy wrote:

Hello,

Could your review the fix for the issue:
  Bug: https://bugs.openjdk.java.net/browse/JDK-8252248
  Fix: http://cr.openjdk.java.net/~alexsch/8252248/webrev.00/

:

The fix has been discussed on the portola-dev alias [2] where it was pointed out that the fix can be reviewed in the mainline and it was suggested to rename the INTERRUPT_SIGNAL and move its definition to net_util_md.h.

The xxx_close.c sources are for the old SocketImpl and DatagramSocketImpl implementations; they are aren't used by default and will eventually go away. Maybe an option for the musl port is to just not compile in the old socket implementations? It might be best to start a discussion on nio-dev and net-dev about this as we shouldn't be changing NativeThread.c (which is used for signalling in the FileChannel implementation) to include net_util.h.

-Alan

Reply via email to