Hi Roger, On Thu, Sep 3, 2020 at 2:20 AM Roger Riggs <roger.ri...@oracle.com> wrote:
> Hi Vipin, > > Looks fine. > > I see you filed separate tasks for the other packages in java.rmi. [1] > That's unnecessarily fine grained. > It would be more efficient to do them all in one code review, saving your > time and reviewers time. > I agree. In the next patch, I will include all remaining occurrences of @exception in the core-libs <https://openjdk.java.net/groups/core-libs/> area. Also, I noticed that those files still use the <code> </code> markup. > Converting them to use {@code ... } is another useful task. > I will take this task. > Thanks, Roger > > [1]https://bugs.openjdk.java.net/browse/JDK-8252536 > Thanks, Vipin