On 09/09/2020 09:27, Philippe Marschall wrote:
Hello
I started working on 8138732 [2] as described in the issue [1]. However
the question about the impact and coordination with other projects came
up, eg.:
- projects that implement their own intrinsics
- Graal
- somebody else?
How do we want to address this and coordinate with these projects?
Given all the possible impact do we still want the issue to be
implemented as described? Or do we want to have it implemented
differently or not at all?
Maybe Igor Veresov or someone else on hotspot-compiler-dev that is
familiar with the process for pulling Graal compiler changes from
upstream could comment in case there is coordination needed. It's just a
move/rename so shouldn't be too disruptive.
There are several projects in OpenJDK with additional instrinics and
they'll just need to switch over when they pull the change from the main
repo, shouldn't be an issue.
I did comment on the update to java.base's module-info.java as I don't
expect that jdk.internal needs to be exported to jdk.jfr with the
change. Once @PreviewFeature moves to java.lang.annotation then that
package will be likely be "empty" so won't be exported to anyone.
-Alan
