Hi Bernd,
Not sure if we should enforce English version of error messages on
non-English locale. I think user will expect messages in system locale
if possible. User can change system locale to English if English version
of error messages are required to submit something like bug report.
Thanks,
Alexander
On 9/12/20 6:45 AM, Bernd Eckenfels wrote:
Hello,
What about system errors (exception messages from strerr?). I mean in case one
wants to enforce English version with user.locale for support reasons?
Gruss
Bernd
--
http://bernd.eckenfels.net
________________________________
Von: core-libs-dev <core-libs-dev-r...@openjdk.java.net> im Auftrag von Alexander
Matveev <almat...@openjdk.java.net>
Gesendet: Saturday, September 12, 2020 4:22:31 AM
An: core-libs-dev@openjdk.java.net <core-libs-dev@openjdk.java.net>
Betreff: RFR: 8223187: Investigate setLocale() call in jpackage native launcher
setlocale() affects several C functions. We do not use most of these functions.
We only using isspace() and toLower().
Based on how we use it I do not see any needs for setlocale(). After removing
it I retested jpackage by changing
locally on machine and using different language as input parameters for
jpackage. No issues found.
-------------
Commit messages:
- 8223187: Investigate setLocale() call in jpackage native launcher
Changes: https://git.openjdk.java.net/jdk/pull/138/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=138&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8223187
Stats: 3 lines in 2 files changed: 0 ins; 3 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/138.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/138/head:pull/138
PR: https://git.openjdk.java.net/jdk/pull/138
