On Tue, 15 Sep 2020 14:30:03 GMT, Alan Bateman <[email protected]> wrote:

>> Ian Graves has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Comparator cleanup
>
> The update using flatMap looks good. I think we need to explore adding more 
> tests if possible.

Thanks for adding a test. What would you think about adding this to 
JLinkReproducible2Test to avoid duplication. The
existing test can be tweaked to do the mismatch check with different sets of 
modules. In passing, no need to include
java.base in the @modules tag.

-------------

PR: https://git.openjdk.java.net/jdk/pull/156

Reply via email to