On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma <vsha...@openjdk.org> wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversation on this: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html > > Vipin Sharma has updated the pull request with a new target base due to a > merge or a rebase. The pull request now > contains one commit: > JDK-8252537 Updated @exception with @throws, implemented review comments Overall the changes look OK. in the java.sql set of classes, please updated the modified statements to also use {@code} src/java.sql/share/classes/java/sql/CallableStatement.java line 131: > 129: * a <code>ARRAY</code>, <code>BLOB</code>, <code>CLOB</code>, > 130: * <code>DATALINK</code>, <code>JAVA_OBJECT</code>, > <code>NCHAR</code>, > 131: * <code>NCLOB</code>, <code>NVARCHAR</code>, > <code>LONGNVARCHAR</code>, Please change to use {@code) as part of the update src/java.sql/share/classes/java/sql/CallableStatement.java line 613: > 611: * a <code>ARRAY</code>, <code>BLOB</code>, <code>CLOB</code>, > 612: * <code>DATALINK</code>, <code>JAVA_OBJECT</code>, > <code>NCHAR</code>, > 613: * <code>NCLOB</code>, <code>NVARCHAR</code>, > <code>LONGNVARCHAR</code>, Same comment regarding {@code} ------------- Changes requested by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/95
