On Wed, 14 Oct 2020 15:01:42 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Due to the requirement for multiple reviewers, I had been waiting to add my >> review of the Core-Libs files until the >> HotSpot reviewers had approved! I see only one reviewer credited in the >> commit. > > This integration without testing with a current merge from the master and has > caused two build failures. > > JDK-8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar > > JDK-8254775: Microbenchmark StringIndexOfChar doesn't compile > > There is a raw unicode character in the JMH test that causes a compilation > error. > == Output from failing command(s) repeated here === > [2020-10-14T14:39:09,608Z] * For target > support_test_micro_classes__the.BUILD_JDK_MICROBENCHMARK_batch: > [2020-10-14T14:39:09,611Z] > /opt/mach5/mesos/work_dir/slaves/4076d11c-c6ed-4d07-84c1-4ab8d55cd975-S108796/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/400e1f56-2d49-42d8-8879-97d4fbb6c909/runs/c49da2bc-a8fe-4a5d-8159-57a9b0316fd2/workspace/open/test/micro/org/openjdk/bench/java/lang/StringIndexOfChar.java:71: > error: unmappable character (0xE2) for encoding ascii > [2020-10-14T14:39:09,611Z] > sb.append(isUtf16?'???':'b'); [2020-10-14T14:39:09,611Z] > ^ [2020-10-14T14:39:09,611Z] > /opt/mach5/mesos/work_dir/slaves/4076d11c-c6ed-4d07-84c1-4ab8d55cd975-S108796/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/400e1f56-2d49-42d8-8879-97d4fbb6c909/runs/c49da2bc-a8fe-4a5d-8159-57a9b0316fd2/workspace/open/test/micro/org/openjdk/bench/java/lang/StringIndexOfChar.java:71: > error: unmappable character (0x98) for encoding ascii > [2020-10-14T14:39:09,611Z] > sb.append(isUtf16?'???':'b'); [2020-10-14T14:39:09,611Z] > ^ [2020-10-14T14:39:09,611Z] > /opt/mach5/mesos/work_dir/slaves/4076d11c-c6ed-4d07-84c1-4ab8d55cd975-S108796/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/400e1f56-2d49-42d8-8879-97d4fbb6c909/runs/c49da2bc-a8fe-4a5d-8159-57a9b0316fd2/workspace/open/test/micro/org/openjdk/bench/java/lang/StringIndexOfChar.java:71: > error: unmappable character (0xBA) for encoding ascii > [2020-10-14T14:39:09,611Z] > sb.append(isUtf16?'???':'b'); [2020-10-14T14:39:09,611Z] > ^ [2020-10-14T14:39:09,611Z] > /opt/mach5/mesos/work_dir/slaves/4076d11c-c6ed-4d07-84c1-4ab8d55cd975-S108796/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/400e1f56-2d49-42d8-8879-97d4fbb6c909/runs/c49da2bc-a8fe-4a5d-8159-57a9b0316fd2/workspace/open/test/micro/org/openjdk/bench/java/lang/StringIndexOfChar.java:71: > error: unclosed character literal [2020-10-14T14:39:09,611Z] > sb.append(isUtf16?'???':'b'); > [2020-10-14T14:39:09,611Z] ^ > [2020-10-14T14:39:09,611Z] > /opt/mach5/mesos/work_dir/slaves/4076d11c-c6ed-4d07-84c1-4ab8d55cd975-S108796/frameworks/1735e8a2-a1db-478c-8104-60c8b0af87dd-0196/executors/400e1f56-2d49-42d8-8879-97d4fbb6c909/runs/c49da2bc-a8fe-4a5d-8159-57a9b0316fd2/workspace/open/test/micro/org/openjdk/bench/java/lang/StringIndexOfChar.java:71: > error: unclosed character literal [2020-10-14T14:39:09,611Z] > sb.append(isUtf16?'???':'b');``` And also a failed Graal test because of the new intrinsic. And JDK-8254785: compiler/graalunit/HotspotTest.java failed with "missing Graal intrinsics for: java/lang/StringLatin1.indexOfChar([BIII)I" @phohensee don't be so quick to type `/sponsor`; there are three separate build and test failures. ------------- PR: https://git.openjdk.java.net/jdk/pull/71
