On Thu, 15 Oct 2020 18:22:12 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Marked as reviewed by dfuchs (Reviewer). > > Please review the corresponding CSR: > https://bugs.openjdk.java.net/browse/JDK-8251991 Hi Roger, This looks very good. I have a few minor comments: 1. Add an explicit type parameter <A extends Appendable> to toHexDigits 2. Some clean opportunities to reduce line lengths in the test. I went ahead and created a PR for these, I hope that it ok. Please take a look https://github.com/RogerRiggs/jdk/pull/1 . ------------- PR: https://git.openjdk.java.net/jdk/pull/482
