On Tue, 20 Oct 2020 11:36:41 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> test/langtools/tools/javac/patterns/LocalVariableTable.java line 29: >> >>> 27: * @summary Ensure the LV table entries are generated for bindings >>> 28: * @modules jdk.jdeps/com.sun.tools.classfile >>> 29: * @compile -g LocalVariableTable.java >> >> I believe all tests are always compiled with `-g` option set, not related to >> your patch but we could probably remove >> that line as superfluous > > I believe plain jtreg invocations may not be always setting "-g". So probably > better to be explicitly clear we need -g, > as the test itself requires the debugging info/LocalVariableTable? sure I understand that the `-g` option is necessary. I was just wondering if `-g` is not passed always by jtreg. If the option is passed by default then it is superfluous, although just a comment, I understand that it is safer to pass it ------------- PR: https://git.openjdk.java.net/jdk/pull/559
