On Wed, 21 Oct 2020 15:25:59 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 35 commits: >> >> - Merge branch 'JDK-8250768-dev' of https://github.com/lahodaj/jdk into >> JDK-8250768 >> - More fixing tests. >> - Fixing tests. >> - Using unique sections for preview warning sections, as suggested. >> - Merge branch 'master' into JDK-8250768 >> - Reflecting review comments. >> - Fixing tests. >> - Various cleanup. >> - The Preview taglet is not needed anymore. >> - There is not jdk.internal package anymore >> - ... and 25 more: >> https://git.openjdk.java.net/jdk/compare/98ec4a67...be1d8651 > > The javadoc code changes look reasonable, and the preview bits in the > generated documentation look good as well. > > Apart from my inline comments which all address minor issues, there are a few > things I don't like around `PreviewListWriter`: its code replication with > `DeprecatedListWriter, and it adds things to HtmlDocletWriter and HtmlStyle > that I don't think are strictly necessary. However, I wouldn't expect you to > know how we like things done in javadoc, so maybe the simplest solution would > be for one of us to go over the javadoc bits, either as part of this pull > request or (if you prefer to get it integrated rather sooner) as a follow-up > task. I have update the patch based on Hannes' comments. One open question is whether we should have Utils.elementFlags, or just Utils.isPreviewElement. @jonathan-gibbons, any preference? Thanks! ------------- PR: https://git.openjdk.java.net/jdk/pull/703
