On Mon, 26 Oct 2020 10:40:27 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> Dong Bo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor improvements for small BigIntegers > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4167: > >> 4165: __ strw(r12, __ post(newArr, 4)); >> 4166: __ sub(numIter, numIter, 1); >> 4167: __ cbz(numIter, Exit); > > This is odd code. Why not `cbnz(numIter, ShiftOneLoop)` ? My bad, it should be cbnz(numIter, ShiftOneLoop). But it's gone now, the ShiftOneLoop is unrolled in the newest version. Do you think we need further modifications? ------------- PR: https://git.openjdk.java.net/jdk/pull/861
