On Sun, 1 Nov 2020 13:20:20 GMT, Kartik Ohri <github.com+27751938+amcap1...@openjdk.org> wrote:
>> Hi ! >> thanks for taking the time to craft that pull request but this is typically >> the kind of patch that should be discussed on the mailing list first before >> creating a pull request. >> >> There are several issues, one is that we want to retrofit OptionalInt, >> OptionalLong, etc to be Optional<int>, Optional<long> as part of project >> Valhalla so we don't want to add more methods in the primitive variants of >> Optional and Stream to avoid to be blocked later while trying retrofitting >> those classes due to these methods. >> So we know that some methods are missing but we want to know first how the >> specialization of generics over primitive types works before adding those >> methods. >> >> The second issue is that when you want to change the public API of the JDK, >> you have to create a CSR to ask to the CSR guys/girls leaded by Joe Darcy if >> the signature and the semantics of the methods you want to add are coherent >> with the rest of the API. >> >> I recommend you to start by fixing bugs because those can be fixed by a >> simple pull request. >> >> regards, >> Rémi > > Thank you for the suggestions. I'll try fixing some bugs first. Should I > close this PR as well or leave it open ? If it doesn't break your hart too much, yes please. ------------- PR: https://git.openjdk.java.net/jdk/pull/857
