On Fri, 6 Nov 2020 21:42:41 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 8219014 >> - Merge branch 'master' into 8254162 >> - Addess remaining feedback from @AlanBateman and @mrserb >> - Address comments from @AlanBateman >> - Fix typo in upcall helper for aarch64 >> - Merge branch '8254162' into 8254231_linker >> - Merge branch 'master' into 8254162 >> - Fix issues with derived buffers and IO operations >> - More 32-bit fixes for TestLayouts >> - ... and 54 more: >> https://git.openjdk.java.net/jdk/compare/a50fdd54...b38afb3f > > src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 55: > >> 53: >> 54: // FIXME: This should be initialized explicitly instead of lazily/racily >> 55: static void upcall_init() { > > The FIXME is right this should be initialized as a well known class and > referred to here as SystemDictionary::ProgrammableUpcallHandler_klass(). > This really doesn't belong here. I agree with Coleen. ------------- PR: https://git.openjdk.java.net/jdk/pull/634
