On Tue, 10 Nov 2020 19:52:14 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder >> method. The motivation and its spec are in this CSR: >> >> https://bugs.openjdk.java.net/browse/JDK-8254629 >> >> Naoto > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Added a test case for user defined temporal field resolution with day > period. test/jdk/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java line 877: > 875: try { > 876: dtf.parse("0 at night"); > 877: throw new RuntimeException("DateTimeParseException should be > thrown"); Testng has `Assert.fail(message)` for this case. ------------- PR: https://git.openjdk.java.net/jdk/pull/938