On Fri, 13 Nov 2020 00:47:19 GMT, Alexander Matveev <[email protected]>
wrote:
>> This is regression from JDK-8242302 and for some reason removing -psn
>> argument code was removed during refactoring. Fixed be adding removing -psn
>> argument back. Also, test was added to test this functionality.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8255947: [macos] Signed macOS jpackage app doesn't filter spurious '-psn'
> argument [v2]
test/jdk/tools/jpackage/macosx/ArgumentsFilteringTest.java line 52:
> 50: public class ArgumentsFilteringTest {
> 51:
> 52: public static void main(String[] args) throws Exception {
Please don't use main() and TKit.run(). Use @Test annotation for methods with
test cases.
Please put each case in separated class method.
You can use BasicTest class as a reference.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1154
