On Mon, 23 Nov 2020 19:25:31 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits since the last revision: >> >> - Merge branch 'master' into Linker_32bit-fixes_New-Master >> - - Add negative test for 32-bit platform. >> - Added note to CLinker about failure to initialize on unsupported >> platforms >> - Remove UnsupportedPlatform test >> - Remove unneeded cast >> - Remove Stuff that makes the jdk_foreign tests pass >> - fix test warnings >> - - Fix 32-bit build errors and tests >> - Add negative test for 32-bit platform. >> - Change CABI to fail more lazily when running on an unsupported platform. >> - Change CLinker layouts to be null on unsupported platforms, instead of >> failing when initializing the class >> - Added note to CLinker about failure to initialize on unsupported >> platforms > > src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/PlatformLayouts.java > line 144: > >> 142: * The {@code T*} native type. >> 143: */ >> 144: public static final ValueLayout C_POINTER = >> ofPointer(LITTLE_ENDIAN, 64); > > I somewhat get the change in `Win64()` and `AArch64()`, but why here at > `SysV()`? Surely x86_32 is the platform with 32-bit pointers? SysV here is the 64-bit SysV ABI, not 32. Perhaps this needs to be disambiguated yet, but we can cross that bridge when adding 32-bit support. Any way, I pushed the wrong thing here. This is supposed to go in another PR. Will fix. ------------- PR: https://git.openjdk.java.net/jdk/pull/1266