On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick <herr...@openjdk.org> wrote:
>> …n name.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8256475: Fix Behavior when Installer name differs from application name.
Looks good.
src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_zh_CN.properties
line 75:
> 73: error.jlink.failed=jlink \u5931\u8D25\uFF0C\u51FA\u73B0 {0}
> 74: error.blocked.option=\u4E0D\u5141\u8BB8\u5728 --jlink-options
> \u4E2D\u4F7F\u7528 jlink \u9009\u9879 [{0}]
> 75: error.no.name=Name not specified with --name and cannot infer one from
> app-image
Do we need to submit a follow-up bug for localization team that we have new
non-localized messages in the region specific properties file? I see that
foreign app image warning is still not localized.
-------------
Marked as reviewed by kizune (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1300
