On Tue, 24 Nov 2020 23:59:11 GMT, David Holmes <[email protected]> wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into Linker_32bit-fixes_Simpler
>> - Remove JNI_ENTRY_CPP_NOENV
>> - - Move reset_last_Java_frame
>> - Use the Unimplemented() macro instead of hlt()
>> - Merge branch 'master' into Linker_32bit-fixes_Simpler
>> - Remove UnsupportedPlatform test
>> - Remove unneeded cast
>> - Remove Stuff that makes the jdk_foreign tests pass
>> - fix test warnings
>> - - Fix 32-bit build errors and tests
>> - Add negative test for 32-bit platform.
>> - Change CABI to fail more lazily when running on an unsupported platform.
>> - Change CLinker layouts to be null on unsupported platforms, instead of
>> failing when initializing the class
>> - Added note to CLinker about failure to initialize on unsupported
>> platforms
>
> src/hotspot/share/prims/universalUpcallHandler.cpp line 37:
>
>> 35:
>> 36: void ProgrammableUpcallHandler::upcall_helper(jobject rec, address buff)
>> {
>> 37: JavaThread* THREAD = JavaThread::current();
>
> You could pass the current thread in rather than re-manifesting it.
Ah, of course. Will fix
-------------
PR: https://git.openjdk.java.net/jdk/pull/1266