On Mon, 23 Nov 2020 15:27:52 GMT, Alan Bateman <[email protected]> wrote:
> This is a corner case that arises when creating a Configuration for a child
> module layer. If an explicit module in the child configuration reads an
> automatic module in a parent configuration then it should read all automatic
> modules in the parent configurations. Unfortunately, this read edge wasn't
> created for the case that the child layer does not contain any automatic
> modules.
Looks good.
src/java.base/share/classes/java/lang/module/Resolver.java line 580:
> 578: if (m2.descriptor().isAutomatic()) {
> 579: m2.reads()
> 580: .stream()
Nit: not sure if this formatting is intentional or you meant
`m2.reads().stream()` in one line (which I like better).
-------------
Marked as reviewed by mchung (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1391
