On Thu, 3 Dec 2020 19:33:14 GMT, Ivan Šipka <isi...@openjdk.org> wrote:

>> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java 
>> test.
>
> Ivan Šipka has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8166026: Refactor java/lang shell tests to java

Changes requested by rriggs (Reviewer).

test/jdk/java/lang/annotation/LoaderLeakTest.java line 65:

> 63:     @Test
> 64:     public void testWithoutReadingAnnotations() throws Throwable {
> 65:         runJavaProcessExpectSuccesExitCode("Main");

Succes -> Success typo.  *Everywhere*

test/jdk/java/lang/annotation/LoaderLeakTest.java line 133:

> 131: class SimpleClassLoader extends ClassLoader {
> 132: 
> 133:     private Hashtable classes = new Hashtable();

A good upgrade would be to use HashMap<String, Class> instead of the ancient 
HashTable.
Also, avoid Raw types and cleanup other compile time warnings.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1577

Reply via email to