On Wed, 18 Nov 2020 07:18:16 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> Michael Edgar has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Update test for jtreg >> - 8255918: Throw XMLStreamExceptions from XMLStreamFilterImpl constructor > > test/jdk/javax/xml/jaxp/parsers/8255918/XMLStreamReaderFilterTest.java line > 38: > >> 36: >> 37: static final String XMLSOURCE1 = "<root>\n" >> 38: + " <element1>\n" > > Change to sth like the following: > /* > * @test > * @bug 8255918 > * @library /javax/xml/jaxp/libs /javax/xml/jaxp/unittest > * @run testng stream.XMLStreamFilterTest.XMLStreamReaderFilterTest > * @summary (general description is fine as future tests can be added, but > add javadoc to the test itself) > */ This comment was shown under "static final String XMLSOURCE1" in the email, though in "Files changed" pane it still is right below the class description "JDK-8255918". The comment meant to be class description, replacing "JDK-8255918". ------------- PR: https://git.openjdk.java.net/jdk/pull/1209
