On Mon, 7 Dec 2020 15:46:11 GMT, Roger Riggs <[email protected]> wrote:
>> Ivan Šipka has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8166026: Refactor java/lang shell tests to java
>
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java line 68:
>
>> 66: @Test(dataProvider = "testCases")
>> 67: public void test(String className, int exitValue, String
>> stdOutMatch, String stdErrMatch) throws Throwable {
>> 68: ProcessBuilder processBuilder =
>> ProcessTools.createJavaProcessBuilder(String.format("Seppuku$%s",className));
>
> The class renaming looks incomplete. Here and in the error texts above.
> Seppuku does not look right as the host class for the test, they are nested
> classes of UncaughtExceptionsTest.
Indeed. Running tests was succeeding because old class files were in place. So
running tests is insufficient, one should run them with a pristine directory
every time.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1578
