On Fri, 11 Dec 2020 05:02:25 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
> Please review this patch which modifies the spec for method > java.lang.Record::equals. It states that the implementation of this method > should use the record fields for the comparison instead of the accessors. > > TIA, > Vicente The change and test look good to me. Thanks Vicente. I have just one minor comment on the location of the test. I know there is not always a clear and clean separation across component areas, but another possible location, for your consideration, is test/jdk/java/lang/reflect/record - which contains other runtime tests for records. ------------- Marked as reviewed by chegar (Reviewer). PR: https://git.openjdk.java.net/jdk16/pull/5
