On Sun, 20 Dec 2020 20:33:43 GMT, Phil Race <p...@openjdk.org> wrote:
>>> One or two of the sources changes should probably uses Files.copy, e.g. >>> ZipPath, sjavac/CopyFile.java. >> >> Good idea! Replaced in few places. But not in ZipPath: it's actually >> implementation of underlying call from Files.copy: >> `jdk.nio.zipfs.ZipFileSystemProvider#copy`. So, `Files.copy` call will be >> recursive. > > So these changes are all over the place which means no one person knows how > to test all of it. > Have you run the sound, swing tests, and the printing tests on unix and > windows ? > For printing for sure you'll need to do some manual testing. I already suggested this, but anyway please always extract the changes to the java.desktop module to the separate PR. ------------- PR: https://git.openjdk.java.net/jdk/pull/1853
