On Fri, 8 Jan 2021 19:35:47 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Limit P11Util::getProvider privileged access to the required
>> 'accessClassInPackage' RuntimePermission only.
>> - New line character inserted at the end of IllegalPackageAccess.java test
>> file
>
> test/jdk/sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java line 96:
>
>> 94: }
>> 95:
>> 96: }
>
> nit: add a newline here, to get rid of the red icon...
Yes, sure. Thanks for your feedback.
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Util.java line
> 102:
>
>> 100: }
>> 101: }
>> 102: });
>
> Sean's suggestion is to add additional arguments here, e.g. null, new
> RuntimePermission("accessClassInPackage." + <pkgName>).
Yes, replied to Sean above. Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1961
