On Wed, 13 Jan 2021 13:11:12 GMT, Andy Herrick <[email protected]> wrote:
>> Sorry, I left this comment earlier, but it was lost. > > I agree is better to have the check in windows specific code (not Platform) > and will move it. > The "os.arch" System property in 32 java is "x86" regardless of whether > running on 64 or 32 bit version of Windows, It reflects the arch of the > running JVM (not the arch of the os as the name implies), so checking if > system property "os.arch" is "x86" is the same as checking if > "sun,arch.data.model" is "32". Since "os.arch" is the more documented > property I think we should continue to use that. (note:) I do build 32 bit java on windows to test this, I can "make CONF=windows-x86 images", but building installers is not supported and currently building test has problems in hotspot. ------------- PR: https://git.openjdk.java.net/jdk/pull/2030
