On 17/01/2021 10:58 pm, David Holmes wrote:
On Fri, 15 Jan 2021 23:50:16 GMT, Alex Menkov <amen...@openjdk.org> wrote:
The fix adds NMT handling for non-java launchers
Alex,
This approach results in two scans of the argument list in the IsJavaArgs case.
I don't know if we care about startup in the non-Java launchers, but this will
likely affect it.
Also, I'm not sure the scanning logic in SetJvmEnvironment is valid for
the IsJavaArgs case. It states:
/*
* Since this must be a VM flag we stop processing once we see
* an argument the launcher would not have processed beyond (such
* as -version or -h), or an argument that indicates the following
* arguments are for the application (i.e. the main class name, or
* the -jar argument).
*/
but the argument rules for other commands are different.
David
David
-------------
PR: https://git.openjdk.java.net/jdk/pull/2106
