On Tue, 2 Feb 2021 02:31:09 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Hello Brian, >> >> Thank you for the review. >> >>> It would be better if there were a test, but apparently this might depend >>> on the user who runs the test not having registry access rights. >> >> That's correct. Looking at the code, it looks to me that this will require >> very specific setup of the Windows system to be able to trigger the error. >> >>> The code change looks all right. >> >> Should I go ahead and integrate this? > >> > The code change looks all right. >> >> Should I go ahead and integrate this? > > Actually, I didn't notice that this PR wasn't marked as reviewed. I'll wait > for the review(s) then. I'd let it sit for a bit in case others want to comment. ------------- PR: https://git.openjdk.java.net/jdk/pull/2326
