On Fri, 29 Jan 2021 00:15:16 GMT, Mark Reinhold <[email protected]> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update package info to credit LMX algorithm
>
> src/java.base/share/classes/java/util/random/RandomGenerator.java line 110:
>
>> 108: /**
>> 109: * Returns an instance of {@link RandomGenerator} that utilizes the
>> 110: * {@code name} algorithm.
>
> Shouldn't this method, and related methods, mention the fact that
> `RandomGenerator` instances are located as services? I see no mention of of
> that fact anywhere, unless I missed it, but I do see the `uses` and
> `provides` declarations in the module declaration. A paragraph explaining how
> services are used here, perhaps in the package specification, would be ideal.
I agree. Will add.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1292
